Dashboard Migration: Add missing e2e selectors to some components #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelavargas
added
patch
29 tasks
dprokop
approved these changes
Mar 20, 2024
Sergej-Vlasov
approved these changes
Apr 24, 2024
|
🚀 PR was released in |
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Dashboard: POC to run existing e2e with dashboardScene feature toggle #84598
To run the existing e2e tests on Grafana core, we need to make sure we have all the
data-testidin the components used there.Note: I am keeping the PR on draft to add the missing
data-testidin one go :)📦 Published PR as canary version:
4.12.3--canary.648.8818501335.0✨ Test out this PR locally via:
npm install @grafana/scenes@4.12.3--canary.648.8818501335.0 # or yarn add @grafana/scenes@4.12.3--canary.648.8818501335.0