Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to opt out specifc queries from time window comparison #650

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

domasx2
Copy link
Contributor

@domasx2 domasx2 commented Mar 20, 2024

Hi!

App o11y has a use case for opting specifc queries out from time window comparison. We're adding anomaly thresholds which should not be compared to thresholds from previous period.

This PR adds timeRangeCompare flag to data query, which can be set to false to prevent this query from being included in previous period request. Does that make sense?

image

@domasx2 domasx2 requested review from torkelo and dprokop March 20, 2024 09:35
@dprokop dprokop changed the title Add ability to opt out specifc queries from TWC Add ability to opt out specifc queries from time window comparison Mar 20, 2024
Copy link
Member

@dprokop dprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it makes sense @domasx2! At some point, when we have comparison available in core Grafana, we'll need to think about graduating timeRangeCompare to DataQuery.

@dprokop dprokop added the minor Increment the minor version when merged label Mar 20, 2024
@domasx2 domasx2 merged commit 542f0f9 into main Mar 20, 2024
3 checks passed
@domasx2 domasx2 deleted the domas-opt-out-of-twc branch March 20, 2024 10:55
@grafanabot
Copy link
Contributor

🚀 PR was released in v3.14.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants