Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControlsLabel: style: use info icons for description #654

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

darrenjaneczek
Copy link
Contributor

There was a UX request to show an explicit info icon whenever a variable had a description.
This PR adds the icon when the description is present, and shows the tooltip when the new icon is on-hover.
The tooltip was removed from the surrounding field component and now will only appear when interacting with the new icon.

image_360

image_360

@darrenjaneczek darrenjaneczek changed the title style: use info icons for description ControlsLabel: style: use info icons for description Mar 20, 2024
Copy link
Member

@torkelo torkelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the wrong size , sound match the font size text

@darrenjaneczek
Copy link
Contributor Author

How is this:
image

image

@darrenjaneczek darrenjaneczek self-assigned this Mar 21, 2024
@torkelo
Copy link
Member

torkelo commented Mar 21, 2024

@darrenjaneczek yes, that works

@darrenjaneczek darrenjaneczek merged commit d16d129 into main Mar 21, 2024
3 checks passed
@darrenjaneczek darrenjaneczek deleted the description-info-icons branch March 21, 2024 18:32
@grafanabot
Copy link
Contributor

🚀 PR was released in v4.0.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants