Fix issue where curly braces are always added to IntervalMacro. #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarkilhed
requested review from
torkelo and
dprokop
and removed request for
torkelo
dprokop
added
patch
dprokop
approved these changes
Apr 2, 2024
torkelo
approved these changes
Apr 2, 2024
oscarkilhed
deleted the
oscark/fix-issue-where-curly-braces-were-added-to-interval-macro
branch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the old architecture
$__intervalwas passed to the backend as$__interval. With scenes this changed so that we're always adding curly braces e.g.${__interval}. The Influx db datasource does not handle this well. So for backwards compatibility we should probably keep the variable as is, without the braces.📦 Published PR as canary version:
4.1.1--canary.666.8521778570.0✨ Test out this PR locally via:
npm install @grafana/scenes@4.1.1--canary.666.8521778570.0 # or yarn add @grafana/scenes@4.1.1--canary.666.8521778570.0