Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SceneRefreshPicker: Show the auto calculated value when auto is selected #680

Merged
merged 7 commits into from
Apr 5, 2024

Conversation

bfmatei
Copy link
Contributor

@bfmatei bfmatei commented Apr 4, 2024

Show the computed auto value when auto is selected.

📦 Published PR as canary version: 4.5.3--canary.680.8568953297.0

✨ Test out this PR locally via:

npm install @grafana/scenes@4.5.3--canary.680.8568953297.0
# or 
yarn add @grafana/scenes@4.5.3--canary.680.8568953297.0

@bfmatei bfmatei added patch Increment the patch version when merged release Create a release when this pr is merged labels Apr 4, 2024
@bfmatei bfmatei requested review from torkelo and dprokop April 4, 2024 14:32
@bfmatei bfmatei self-assigned this Apr 4, 2024
@bfmatei bfmatei changed the title SceneRefreshPicker: Listen to window resize and show auto value SceneRefreshPicker: Show the auto calculated value when auto is selected Apr 5, 2024
Copy link
Member

@dprokop dprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one issue, when you change refresh interval from Auto to something else, the label does not go away:

Screen.Recording.2024-04-05.at.11.40.14.mov

@bfmatei
Copy link
Contributor Author

bfmatei commented Apr 5, 2024

@dprokop - fixed!

@bfmatei bfmatei requested a review from dprokop April 5, 2024 11:16
@bfmatei bfmatei merged commit 7679ef0 into main Apr 5, 2024
3 checks passed
@bfmatei bfmatei deleted the bogdan/improve-refresh-picker-auto branch April 5, 2024 13:27
@grafanabot
Copy link
Contributor

🚀 PR was released in v4.5.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants