Clone SceneQueryRunner together with _results #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
mdvictor
added
patch
mdvictor
requested review from
dprokop,
torkelo,
ivanortegaalba,
bfmatei and
kaydelaney
torkelo
approved these changes
Apr 5, 2024
torkelo
reviewed
Apr 5, 2024
| @@ -421,6 +421,8 @@ export class SceneQueryRunner extends SceneObjectBase<QueryRunnerState> implemen | |||
| clone['_layerAnnotations'] = this._layerAnnotations.map((frame) => ({ ...frame })); | |||
| } | |||
|
|
|||
| clone['_results'].next({ origin: this, data: this.state.data }); | |||
|
This should also fix grafana/grafana#84573 right? UPDATE: ah of course not, it's completely different thing :) |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes grafana/grafana#84575
Fixes an issue where the DashboardDS would not get the correct data from the source panels
SceneQueryRunner._resultsbecause the source panel_resultsbuffer would be empty. This affected the dashboard DS in various scenarios but was observed consistently when creating a new dashboard.In a new dashboard, if you would create a new panel, it's
_resultsbuffer in the query runner would be empty. As soon as you saved the dashboard and refreshed the page the buffer would populate and thus the DashboardDS would also work.The problem was in
SceneQueryRunnercloning where we now emit the data in the clone so it can be picked up by the DashboardDS.📦 Published PR as canary version:
4.5.4--canary.681.8570869587.0✨ Test out this PR locally via:
npm install @grafana/scenes@4.5.4--canary.681.8570869587.0 # or yarn add @grafana/scenes@4.5.4--canary.681.8570869587.0