Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalValueVariable: Do not throw when missing parent variable #691

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented Apr 15, 2024

Alternative to grafana/grafana#85934

I think if we have to do that try catch there, might just be simpler to support this scenario in LocalValueVariable

Copy link
Contributor

@mdvictor mdvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@torkelo torkelo added minor Increment the minor version when merged release Create a release when this pr is merged labels Apr 15, 2024
@torkelo torkelo merged commit da0861f into main Apr 15, 2024
3 checks passed
@torkelo torkelo deleted the local-variable-value-no-parrent branch April 15, 2024 07:43
@grafanabot
Copy link
Contributor

🚀 PR was released in v4.8.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants