SceneComponentWrapper: More robust activation #692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion fix to grafana/grafana#86093 to make sure bugs like that cannot happen again by fixing the issue in SceneComponentWrapper so that we never render model components before they are activated.
📦 Published PR as canary version:
4.7.0--canary.692.8683393495.0
✨ Test out this PR locally via:
npm install @grafana/scenes@4.7.0--canary.692.8683393495.0 # or yarn add @grafana/scenes@4.7.0--canary.692.8683393495.0