Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ${__all_variables} not updating their value in panels #698

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

axelavargas
Copy link
Member

Issue reported here Dashboard Migration: ${__all_variables} not updating their value in panels #86296

I noticed that $__all_variables is not being updated when a variable changes. I lack context in this area, and this is my attempt to understand it.

Is there a better way to fix this issue?

FixAllVariablesBeingUpdated.mp4

@axelavargas axelavargas added type/bug Something isn't working minor Increment the minor version when merged area/variables Issues related to variables system in scenes labels Apr 16, 2024
@axelavargas axelavargas self-assigned this Apr 16, 2024
Copy link
Member

@torkelo torkelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but we have a constant for the __all_variables variable exported from data package, DataLinkBuiltInVars.includeVars

packages/scenes/src/variables/VariableDependencyConfig.ts Outdated Show resolved Hide resolved
Copy link
Member

@dprokop dprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM / please apply Torkel's comment.

@axelavargas axelavargas added the release Create a release when this pr is merged label Apr 17, 2024
@axelavargas axelavargas merged commit fcd79b0 into main Apr 17, 2024
3 checks passed
@axelavargas axelavargas deleted the axelav/all-variables-dep branch April 17, 2024 07:20
@grafanabot
Copy link
Contributor

🚀 PR was released in v4.11.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/variables Issues related to variables system in scenes minor Increment the minor version when merged release Create a release when this pr is merged released type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants