Add method to get ancestor for localValueVariable #699
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain scenarios (e.g.: grafana/grafana#84915) where we repeat a panel under a repeated row using the same variable, the
DashboardGridItem._performRepeat
looks up and finds the variable in the grid row, since they have the same name, and since that is aLocalValueVariable
it cannot perform the repeat with it.With this method we can get the parent variable of the
LocalValueVariable
and use that to repeat.Needed by grafana/grafana#86425
📦 Published PR as canary version:
4.11.1--canary.699.8720696583.0
✨ Test out this PR locally via:
npm install @grafana/scenes@4.11.1--canary.699.8720696583.0 # or yarn add @grafana/scenes@4.11.1--canary.699.8720696583.0