sceneGraph: handle interpolations argument in interpolate #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the same functionality as is present in Grafana's `TemplateSrv`, allowing users to pass an array as the fifth argument to `interpolate` and have it populated with `VariableInterpolation`s indicating whether the variable was found and containing some details about the match.
sd2k
added a commit
to grafana/grafana
that referenced
this pull request
Apr 26, 2024
TemplateSrv.replace takes an optional 'interpolations' argument which records information about the variables which were found during the interpolation. Until [this Scenes PR][scenes PR] this wasn't supported by Scenes so the interpolations argument was being ignored if dashboard scenes were enabled. This commit updates the scenes version and passes the interpolations array along. [scenes PR]: grafana/scenes#708
torkelo
approved these changes
Apr 26, 2024
torkelo
added
minor
|
🚀 PR was released in |
sd2k
added a commit
to grafana/grafana
that referenced
this pull request
Apr 26, 2024
TemplateSrv.replace takes an optional 'interpolations' argument which records information about the variables which were found during the interpolation. Until [this Scenes PR][scenes PR] this wasn't supported by Scenes so the interpolations argument was being ignored if dashboard scenes were enabled. This commit bumps the scenes version and passes the interpolations array along to the scenes function. [scenes PR]: grafana/scenes#708
3 tasks
sd2k
added a commit
to grafana/grafana
that referenced
this pull request
Apr 26, 2024
TemplateSrv.replace takes an optional 'interpolations' argument which records information about the variables which were found during the interpolation. Until [this Scenes PR][scenes PR] this wasn't supported by Scenes so the interpolations argument was being ignored if dashboard scenes were enabled. This commit bumps the scenes version and passes the interpolations array along to the scenes function. [scenes PR]: grafana/scenes#708
sd2k
added a commit
to grafana/grafana
that referenced
this pull request
Apr 26, 2024
TemplateSrv.replace takes an optional 'interpolations' argument which records information about the variables which were found during the interpolation. Until [this Scenes PR][scenes PR] this wasn't supported by Scenes so the interpolations argument was being ignored if dashboard scenes were enabled. This commit bumps the scenes version and passes the interpolations array along to the scenes function. [scenes PR]: grafana/scenes#708
sd2k
added a commit
to grafana/grafana
that referenced
this pull request
Apr 26, 2024
TemplateSrv.replace takes an optional 'interpolations' argument which records information about the variables which were found during the interpolation. Until [this Scenes PR][scenes PR] this wasn't supported by Scenes so the interpolations argument was being ignored if dashboard scenes were enabled. This commit bumps the scenes version and passes the interpolations array along to the scenes function. [scenes PR]: grafana/scenes#708
sd2k
added a commit
to grafana/grafana
that referenced
this pull request
Apr 26, 2024
TemplateSrv.replace takes an optional 'interpolations' argument which records information about the variables which were found during the interpolation. Until [this Scenes PR][scenes PR] this wasn't supported by Scenes so the interpolations argument was being ignored if dashboard scenes were enabled. This commit bumps the scenes version and passes the interpolations array along to the scenes function. [scenes PR]: grafana/scenes#708
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the same functionality as is present in Grafana's
TemplateSrv,allowing users to pass an array as the fifth argument to
interpolateandhave it populated with
VariableInterpolations indicating whether thevariable was found and containing some details about the match.