Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdHoc filters: Allow adding custom value while loading #721

Merged
merged 2 commits into from
May 7, 2024

Conversation

ashharrison90
Copy link
Contributor

@ashharrison90 ashharrison90 commented May 7, 2024

  • adds the allowCreateWhileLoading option to the value select
  • adjusts when isValuesOpen is set to true to be as soon as the onClick is fired. otherwise the menu will reopen once the options finally resolve even if you've already selected and added a custom value

Fixes https://github.com/grafana/hyperion-planning/issues/23

📦 Published PR as canary version: 4.14.2--canary.721.8986239090.0

✨ Test out this PR locally via:

npm install @grafana/scenes@4.14.2--canary.721.8986239090.0
# or 
yarn add @grafana/scenes@4.14.2--canary.721.8986239090.0

@ashharrison90 ashharrison90 added type/enhancement New feature or request patch Increment the patch version when merged release Create a release when this pr is merged labels May 7, 2024
@ashharrison90 ashharrison90 self-assigned this May 7, 2024
Copy link
Member

@dprokop dprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ashharrison90 ashharrison90 merged commit 2cdb6d8 into main May 7, 2024
3 checks passed
@ashharrison90 ashharrison90 deleted the ash/custom-value-while-loading branch May 7, 2024 14:20
@grafanabot
Copy link
Contributor

🚀 PR was released in v4.14.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants