Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdHoc filters: Allow typing the same custom value #723

Merged
merged 1 commit into from
May 9, 2024

Conversation

ashharrison90
Copy link
Contributor

@ashharrison90 ashharrison90 commented May 8, 2024

  • passes a custom isValidNewOption function to the valueSelect
    • allows any non-zero-length string as a valid option
    • this prevents showing a No options found message when entering the same custom value as was initially present
  • adds a unit test to prevent regressions

Fixes https://github.com/grafana/hyperion-planning/issues/25

📦 Published PR as canary version: 4.17.2--canary.723.8999827741.0

✨ Test out this PR locally via:

npm install @grafana/scenes@4.17.2--canary.723.8999827741.0
# or 
yarn add @grafana/scenes@4.17.2--canary.723.8999827741.0

@ashharrison90 ashharrison90 added type/bug Something isn't working patch Increment the patch version when merged release Create a release when this pr is merged labels May 8, 2024
@ashharrison90 ashharrison90 self-assigned this May 8, 2024
@ashharrison90 ashharrison90 merged commit 8f7fd69 into main May 9, 2024
3 checks passed
@ashharrison90 ashharrison90 deleted the ash/same-custom-value branch May 9, 2024 10:32
@grafanabot
Copy link
Contributor

🚀 PR was released in v4.17.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants