Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables: Do not update value when value and text are the same #726

Merged
merged 2 commits into from
May 10, 2024

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented May 9, 2024

Fixes an annoying issue where a multi-value variable would trigger a cascading update even when the value did not change, for example when just opening the variable multi select and closing it without changing anything

@torkelo torkelo added the minor Increment the minor version when merged label May 9, 2024
Copy link
Member

@dprokop dprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against main an works as expected. Nice catch with the query being executed after no changes are made.

@torkelo torkelo merged commit d62c65d into main May 10, 2024
3 checks passed
@torkelo torkelo deleted the variable-do-not-update-value-when-same branch May 10, 2024 09:29
@grafanabot
Copy link
Contributor

🚀 PR was released in v4.19.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants