SceneGridLayout: Prevent panels from moving on mount #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -138,6 +147,18 @@ function validateChildrenSize(children: SceneGridItemLike[]) { | |||
| } | |||
| } | |||
|
|
|||
| function updateAnimationClass(ref: React.MutableRefObject<HTMLDivElement>, isDraggable: boolean, retry?: boolean) { | |||
There was a problem hiding this comment.
It works! Question out of curiosity. Could just use the dependencies array from useEffect to rerun the class adjustment when the ref or ref.current changes?
There was a problem hiding this comment.
@ivanortegaalba useEffects are not triggerred when a useRef changes, for that we would have to store the ref in a useState (which would re-render the whole grid and loose the point of using the ref to set class)
Initializing to null the ref to be compatible with LegacyRef
ivanortegaalba
approved these changes
May 10, 2024
There was a problem hiding this comment.
@torkelo I pushed a small commit to fix the types errors, caused by a known React type issue. I hope you don't mind 😄
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed panels moving about when coming back to dashboard from dashboard settings and sometimes from panel edit.
This fixes that problem, I am using a ref here and updating the class using dom classList to avoid having to always re-render the full grid after mount