Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NestedScene: Don't show cursor: pointer; for everything #735

Merged
merged 1 commit into from
May 13, 2024
Merged

NestedScene: Don't show cursor: pointer; for everything #735

merged 1 commit into from
May 13, 2024

Conversation

ashharrison90
Copy link
Contributor

  • removes cursor: pointer; from the NestedScene wrapper
  • might be missing something, but i don't think this is necessary
  • most obvious place to spot the problems this causes is the alerting landing page in ops
  • everything under Insights shows a pointer cursor 馃く
  • this means it can look like something is clickable when it's not (e.g. try clicking in the gap to the right of Grafana-managed alert rules)

@ashharrison90 ashharrison90 added type/bug Something isn't working patch Increment the patch version when merged labels May 13, 2024
@ashharrison90 ashharrison90 self-assigned this May 13, 2024
dprokop
dprokop approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@dprokop dprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that was a mistake :)

@ashharrison90 ashharrison90 merged commit ae03cb6 into main May 13, 2024
3 checks passed
@ashharrison90 ashharrison90 deleted the ash/remove-nested-scene-pointer branch May 13, 2024 13:41
@grafanabot
Copy link
Contributor

馃殌 PR was released in v4.21.0 馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkelo torkelo torkelo approved these changes

@dprokop dprokop dprokop approved these changes

Assignees

@ashharrison90 ashharrison90

Labels
patch Increment the patch version when merged released type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashharrison90 @grafanabot @torkelo @dprokop