Scenes: Set correct default options on plugin load #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -180,7 +181,7 @@ export class VizPanel<TOptions = {}, TFieldConfig extends {} = {}> extends Scene | |||
| plugin, | |||
| currentOptions: panel.options, | |||
| currentFieldConfig: panel.fieldConfig, | |||
| isAfterPluginChange: false, | |||
| isAfterPluginChange: this.state.isAfterPluginChange ?? false, | |||
There was a problem hiding this comment.
An alternative to this is tackling it from the VizPanel.
The problem is when we create a VizPanel, if a VizPanel is created it cannot be after a plugin change. If the VizPanel needs to know when the plugin changes, my approach would be to implement in the VizPanel a method to change the plugin that manages all the logic when the plugin changes in the VizPanel.
All this logic is nowadays managed by VizPanelManager but I'd have it in the VizPanel instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new state flag to allow getting default options after plugin type change.
Fixes grafana/grafana#89836