SceneGridLayout: Change to useMeasure and non absolute div wrapper #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
requested review from
ashharrison90,
mdvictor,
kaydelaney and
axelavargas
torkelo
added
release
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make the sticky controls work we cannot have an absolute wrapper around the grid (as this makes the div there the sticky lives not get the needed hight for sticky to work).
But in changing this to useMeasure and same CSS as in
https://github.com/grafana/grafana/blob/main/public/app/features/dashboard/dashgrid/DashboardGrid.tsx#L327
but I am running into the same problem I have always had in that when the wrapping div is not absolute I cannot reduce the size, the resize observer is not register any change to reduced viewport as the inner grid div current width is blocking a reduction in size.
Have no idea why it works in DashboardGrid.tsx#L327