This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Add support for Starlark export #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kminehart
suggested changes
Apr 29, 2022
kminehart
reviewed
May 4, 2022
| @@ -197,9 +204,7 @@ func (c *Client) renderStarlark(cfg []yaml.Resource) error { | |||
| for _, resource := range cfg { | |||
| switch t := resource.(type) { | |||
| case *yaml.Pipeline: | |||
| pipeline := resource.(*yaml.Pipeline) | |||
|
|
|||
| sl.MarshalPipeline(pipeline) | |||
There was a problem hiding this comment.
My gut tells me that this could really return an error. Are there any places in this function where errors are being ignored or not returned?
There was a problem hiding this comment.
When I first wrote this, I had all the err:= stuff in it. Then I eventually removed it because there was nothing that actually emitted an error.
malcolmholmes
force-pushed
the
malcolmholmes/add-starlark
branch
from
5193024
to
ec5a31e
Compare
kminehart
suggested changes
May 13, 2022
Co-authored-by: Kevin Minehart <kmineh0151@gmail.com>
Co-authored-by: Kevin Minehart <kmineh0151@gmail.com>
kminehart
approved these changes
May 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Drone builds that are already using Starlark, being able to export a
Shipwright build as Starlark will allow the import of a Shipwright
build into the Starlark one, making possible a gradual transition from
one build tool to the other.