This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
add support for docker builds #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callum Styan <callumstyan@gmail.com>
kminehart
approved these changes
Aug 19, 2022
docker/docker.go
Outdated
| return client | ||
| } | ||
|
|
||
| func BuildImage(image Image, arg pipeline.Argument) pipeline.Step { |
There was a problem hiding this comment.
Suggested change
| func BuildImage(image Image, arg pipeline.Argument) pipeline.Step { | |
| func BuildImage(image Image, versionArg pipeline.Argument) pipeline.Step { |
docker/docker.go
Outdated
| } | ||
|
|
||
| return pipeline.NewStep(action). | ||
| WithArguments(pipeline.ArgumentSourceFS, pipeline.ArgumentDockerSocketFS, arg) |
There was a problem hiding this comment.
Suggested change
| WithArguments(pipeline.ArgumentSourceFS, pipeline.ArgumentDockerSocketFS, arg) | |
| WithArguments(pipeline.ArgumentSourceFS, pipeline.ArgumentDockerSocketFS, versionArg) |
docker/docker.go
Outdated
| func BuildImage(image Image, arg pipeline.Argument) pipeline.Step { | ||
| action := func(ctx context.Context, opts pipeline.ActionOpts) error { | ||
| client := Client() | ||
| version := opts.State.MustGetString(arg) |
There was a problem hiding this comment.
Suggested change
| version := opts.State.MustGetString(arg) | |
| version := opts.State.MustGetString(versionArg) |
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly copy pasta of your existing docker build code
Signed-off-by: Callum Styan callumstyan@gmail.com