Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry Events support #100

Merged
merged 3 commits into from Oct 11, 2023

Conversation

olegpixel
Copy link
Contributor

This pull request introduces support for Sentry Events into the Sentry plugin for Grafana. Users can now seamlessly monitor and analyse Sentry events within Grafana.

image

This change will address and resolve the issue #37

@olegpixel olegpixel requested a review from a team as a code owner October 3, 2023 23:18
@olegpixel olegpixel requested review from asimpson, bossinc, aangelisc and adamyeats and removed request for a team October 3, 2023 23:18
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @olegpixel! Thank you for the contribution😊 It LGTM, would you be able to update tests for handlers_query.go and replace.ts based on these changes?

@olegpixel
Copy link
Contributor Author

Hi @aangelisc. Thank you for your feedback.

I've added unit tests for handlers_query.go and replace.ts based on the changes made, as well as updated README file with information related to Events.

Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @olegpixel!

@aangelisc aangelisc merged commit e64c2c2 into grafana:main Oct 11, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants