Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing RED metrics #9

Merged
merged 3 commits into from
Feb 8, 2021
Merged

Implementing RED metrics #9

merged 3 commits into from
Feb 8, 2021

Conversation

dannykopping
Copy link

No description provided.

Danny Kopping added 3 commits February 8, 2021 14:17
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Minor refactoring

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Copy link
Member

@electron0zero electron0zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

main.go Show resolved Hide resolved
@dannykopping dannykopping merged commit d204de6 into master Feb 8, 2021
@dannykopping dannykopping deleted the dannykopping/metrics branch February 8, 2021 18:02
dannykopping pushed a commit that referenced this pull request Mar 9, 2021
#9)

* Expand allowedUsers email field to support comma-separated and domains

Closes #8

* Refactor AuthFetch() to return AuthUser struct

Also, this breaks out a parseLine() function which can be easily tested.

* Ignore empty addrs after splitting commas

This ignores a trailing comma

* Add tests for auth parseLine()

* Update documentation in smtprelay.ini

* Fix bug where addrAllowed() was incorrectly case-sensitive

* Update allowedUsers allowed domain format to require leading @

This disambiguates a local user ('john.smith') from a domain ('example.com')
hairyhenderson added a commit that referenced this pull request Dec 7, 2023
Cherry-picked from upstream in #18, as well as supporting commits
from #7 and #9.
hairyhenderson added a commit that referenced this pull request Dec 7, 2023
Cherry-picked from upstream in #18, as well as supporting commits
from #7 and #9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants