Silence promauto metrics from Global registry #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
tpaschalis
changed the title
v-zhuravlev
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paschalis Tsilias paschalis.tsilias@grafana.com
This is for the first iteration of the SNMP integration in grafana/agent#1364. We would like to avoid these metrics to the Global registry and the root /metrics.
Regarding the v1 SNMP integration cannot have a second endpoint, so there's no great way of presenting these internal metrics.
Regarding the v2 SNMP integration, we could add these 'internal' metrics back in a future improvement PR, exposed on a different endpoint. One solution would be to pass a
prometheus.Registererin our constructor, and use that to register those metrics.Let me know if you think this is an acceptable solution as an MVP :)