-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial exporter implementation #1
Conversation
@v-zhuravlev @Dasomeone This PR is ready for review! |
Awesome, thanks! Will try to get to this as soon as possible this week :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me! Works well out of the box once configured, just one minor point about the default warehouse selection not working if the parameter is not supplied.
Great work! :)
Works well out of the box. LGTM. One question: When I fail to connect to snowflake from snowflake_exporter
There is no metric returned to highlight that snowflake_exporter cannot connect to snowflake app. Could it be added for simple alerting? Like snowflake_up to indicate that whether connection is successful or not. |
@v-zhuravlev I've added a |
Thanks, works perfect, thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you for making these changes :)
This PR contains the initial implementation of the Snowflake exporter.
This PR contains some tooling as well, including the prometheus common makefile, and a Dockerfile (the Docker image can be built by running
make promu; promu crossbuild; make docker
)Sample metrics output