Add mixin for exporter metrics #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
General comment on both dashboards, because I didn't notice this as much in the initial screenshots: A lot of the panels feel oversized, both in terms of height and width, especially the 24 column wide panels. I'd suggest compressing them to at most 12 columns, which would let you fit most of the dashboard in a single view, without too much scrolling. |
Dasomeone
reviewed
Jan 4, 2023
| // for alerts | ||
| alertsWarningLoginFailures: '30', // % | ||
| alertsComputeCreditUsageLimit: '5', // credits/hr | ||
| alertsServiceCreditUsageLimit: '1', // credits/hr |
There was a problem hiding this comment.
I wonder how common these credit usage limits would be for orgs of varying sizes 🤔
In the future, this is definitely something we want to be configurable within the integration setup/settings
Dasomeone
approved these changes
Jan 4, 2023
v-zhuravlev
approved these changes
Jan 7, 2023
Co-authored-by: Vitaly <v-zhuravlev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 2 dashboards and 6 alerts for the Snowflake exporter.