Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warehouse load metric unit descriptions #3

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Fix warehouse load metric unit descriptions #3

merged 4 commits into from
Jan 11, 2023

Conversation

BinaryFissionGames
Copy link
Contributor

The warehouse load metrics are "load values", as described here: https://docs.snowflake.com/en/sql-reference/account-usage/warehouse_load_history.html

"the query load value is the ratio of the total execution time (in seconds) of all queries in a specific state in an interval by the total time (in seconds) for that interval"

This PR updates the description of the load metrics to clarify this, as well as the units & legend on the panel in the mixin.

This PR also adds in some unit exceptions in the .lint file, which weren't caught due to an outdated version of mixtool being used.

@BinaryFissionGames BinaryFissionGames marked this pull request as ready for review January 11, 2023 16:10
Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for catching it!
Could you take an updated screenshot and send it my way? Will update the version in CDN

@Dasomeone Dasomeone merged commit a8e2831 into grafana:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants