-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CODEOWNERS file #104
Add CODEOWNERS file #104
Conversation
|
Tagging the following squads for visibility: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, just want to confirm, this doesn't mean changes are blocked by having all squads review yeah? If one reviewer approves on behalf of the squad and the rest are optional to review, is that "enough"? I think probably? Just wanted to double check we're not setting something where we have to have a reviewer from every squad before it's able to be merged (which is arguably reasonable, but I think maybe a bit much?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@sarahzinger yep we definitely don't want to block, a review from a single codeowner should be sufficient 😊 |
2514737
to
dc7c4cb
Compare
No description provided.