Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS file #104

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Add CODEOWNERS file #104

merged 1 commit into from
Jan 18, 2024

Conversation

adamyeats
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@aangelisc aangelisc requested review from a team, fridgepoet and sarahzinger and removed request for a team November 20, 2023 17:37
@aangelisc
Copy link

Tagging the following squads for visibility:
@grafana/aws-datasources
@grafana/enterprise-datasources
@grafana/oss-big-tent

Copy link
Member

@sarahzinger sarahzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, just want to confirm, this doesn't mean changes are blocked by having all squads review yeah? If one reviewer approves on behalf of the squad and the rest are optional to review, is that "enough"? I think probably? Just wanted to double check we're not setting something where we have to have a reviewer from every squad before it's able to be merged (which is arguably reasonable, but I think maybe a bit much?)

Copy link
Contributor

@gabor gabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aangelisc
Copy link

@sarahzinger yep we definitely don't want to block, a review from a single codeowner should be sufficient 😊

.github/CODEOWNERS Outdated Show resolved Hide resolved
@fridgepoet fridgepoet removed their request for review November 30, 2023 11:05
@adamyeats adamyeats merged commit 41d1be9 into main Jan 18, 2024
3 checks passed
@adamyeats adamyeats deleted the add-codeowners branch January 18, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants