Use automatic instance management #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm I think that is OK. |
kminehart
approved these changes
Jun 4, 2021
|
I've only tested this with the redshift driver that is currently under development. Would you mind testing this with snowflake and make sure everything still works as expected? |
|
yeah i'll give it a shot real quick LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use automatic instance management to simplify sqlds code a bit and to enable debug support in host plugin. Maybe this could have been introduced in a way that is also backwards compatible with the manage signature? On the other hand, it might be a good time to introduce breaking changes now that there's still not that many consumers of this package. WDYT?