Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to return tables, schemas and columns as resources #21

Merged
merged 5 commits into from
Jul 6, 2021

Conversation

andresmgot
Copy link
Collaborator

@andresmgot andresmgot commented Jul 2, 2021

fixes #19

Still need to write some tests but I wanted to verify the approach first :)

@andresmgot andresmgot requested a review from kminehart July 2, 2021 15:14
completable.go Outdated Show resolved Hide resolved
datasource.go Outdated Show resolved Hide resolved
datasource.go Outdated Show resolved Hide resolved
datasource.go Outdated Show resolved Hide resolved
@kminehart
Copy link
Collaborator

Thanks! This makes sense, and was definitely what I was thinking of :)

Copy link
Collaborator

@kminehart kminehart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good! thanks for adding the tests.

Last thing is maybe we might want to move this into another file like completion.go or something similar. Otherwise, LGTM. Feel free to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let driver implement CallResourceHandler
2 participants