Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return error frame during macro parsing errors #37

Merged
merged 1 commit into from
Sep 2, 2021
Merged

return error frame during macro parsing errors #37

merged 1 commit into from
Sep 2, 2021

Conversation

yesoreyeram
Copy link
Contributor

No description provided.

@yesoreyeram yesoreyeram marked this pull request as ready for review September 2, 2021 12:31
kminehart
kminehart approved these changes Sep 2, 2021
View reviewed changes
Copy link
Collaborator

@kminehart kminehart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for future refactors: I wonder if there's a way that we could set this up so that we didn't have to call the same function every time we return an error 👀

@yesoreyeram
Copy link
Contributor Author

yesoreyeram commented Sep 2, 2021 •
edited

Note for future refactors: I wonder if there's a way that we could set this up so that we didn't have to call the same function every time we return an error 👀

Yea. I thought the same. we can handle it here https://github.com/grafana/sqlds/blob/main/datasource.go#L87

@yesoreyeram yesoreyeram merged commit c316d75 into main Sep 2, 2021
@sasklacz sasklacz deleted the errors-in-macros branch January 9, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kminehart kminehart kminehart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yesoreyeram @kminehart