Update Completable interface with custom options #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kminehart
requested changes
Oct 14, 2021
completion.go
Outdated
Comment on lines
50
to
54
| err := json.NewDecoder(req.Body).Decode(&options) | ||
| if err != nil { | ||
| handleError(rw, err) | ||
| return | ||
| } |
There was a problem hiding this comment.
Suggested change
| err := json.NewDecoder(req.Body).Decode(&options) | |
| if err != nil { | |
| handleError(rw, err) | |
| return | |
| } | |
| if err := json.NewDecoder(req.Body).Decode(&options); err != nil { | |
| handleError(rw, err) | |
| return | |
| } |
There was a problem hiding this comment.
x3
I see lots of very similar blocks for decoding Options from req.Body, do you think we should put it into its own function?
I wager there also be a refactor opportunity with handleError where we could call another function that actually returns an error and just handleError once.
kminehart
approved these changes
Oct 14, 2021
I'm going to go ahead and release v2.3 (rather than a major) so people don't need to change the import path and everything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46
Note that this is a breaking change since the
Completableinterface has different parameters but the only datasources that use them are the ones I maintain (so I will change them after this PR). Do you think we should bump the major version anyway?