Refactor regex part of macros #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
reviewed
Dec 14, 2021
There was a problem hiding this comment.
Thanks @fridgepoet! I have some suggestions. BTW, can you add some description in the PR? This is useful for other people to understand why you are making the change (and to leave it in the history).
macros_test.go
Outdated
| assert.Equal(t, `\$__some_string\b(?:\((.*?)\))?`, getMacroRegex("some_string")) | ||
| } | ||
|
|
||
| func TestGetMatches_does_not_match_for_macro_name_which_is_substring(t *testing.T) { |
There was a problem hiding this comment.
to have them all under the same test, you can move this to another t.Run within TestGetMacroRegex
There was a problem hiding this comment.
Thanks
My mistake. It's now separated into the test for getMacroRegex and getMatches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will extract the matching of macro name and the extraction of fields in rawSQL in a separate function to facilitate testing.