Improve error handling for invalid queries #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
reviewed
May 12, 2022
There was a problem hiding this comment.
Thanks for the patch @nineinchnick! I have a small suggestion here.
nineinchnick
force-pushed
the
handle-invalid-queries
branch
from
75d2fae
to
4bc1202
Compare
|
released 2.3.8 with your change so it can be used by plugins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the frontend sends an invalid query, the backend plugin will panic because it tries to decode error frames from a nil object. Also, the actual error message from the JSON decoder is not returned or logged. This PR tries to address this.