Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix map write panic #88

Merged
merged 3 commits into from
Mar 9, 2023
Merged

fix map write panic #88

merged 3 commits into from
Mar 9, 2023

Conversation

scottlepp
Copy link
Collaborator

@scottlepp scottlepp commented Mar 9, 2023 •
edited

as concurrent queries run, writing directly to the driver.macros can cause a panic with concurrent writers

@scottlepp scottlepp requested a review from a team March 9, 2023 21:15
@scottlepp scottlepp merged commit 37ace62 into main Mar 9, 2023
@scottlepp scottlepp deleted the fix-map-write-panic branch March 9, 2023 21:42
@sasklacz
Copy link
Contributor

@scottlepp hwas this triggered by some escalation or or you fixed it before it actually hit us in any way ?

@scottlepp
Copy link
Collaborator Author

I saw it happen a couple times whenI was running some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scottlepp @sasklacz