forward headers #90
Merged
forward headers #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forward headers for sql datasources. this allows pass through oauth tokens
this was a bit hard to do without breaking compatibility
when a sql ds first connects, it happens before queryData/checkHealth. so it will not have the headers yet since those are applied as middleware on queryData and checkHealth. so the first "ping" will fail. sqlds allows retries and defining what errors to retry on, so the datasource can retry on "bad token" or whatever the underlying database returns. then retry will then reconnect and will have the headers available and a new connection is established with the headers