Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow capability for implementing datasources to set query args #95

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

conor-mcavoy
Copy link
Contributor

@conor-mcavoy conor-mcavoy commented Jul 24, 2023

Similar to the optional interfaces that allow datasources to mutate queries and responses, this implements the ability for datasources to set query args in the call QueryDB. Right now, this interface's method SetQueryArgs takes the HTTP headers (you could use this to set the username for example), but it could easily be expanded to allow for other parameters.

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

driver.go Outdated Show resolved Hide resolved
@conor-mcavoy conor-mcavoy marked this pull request as draft July 24, 2023 22:58
@conor-mcavoy conor-mcavoy marked this pull request as ready for review July 25, 2023 00:54
@conor-mcavoy conor-mcavoy marked this pull request as draft July 25, 2023 18:25
@conor-mcavoy conor-mcavoy changed the title Allow capability for implementing datasources to mutate headers Allow capability for implementing datasources to set query args Jul 28, 2023
@conor-mcavoy conor-mcavoy marked this pull request as ready for review July 28, 2023 00:02
@andresmgot andresmgot merged commit d8a7dac into grafana:main Aug 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants