Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macros/Multi param function args #98

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

bossinc
Copy link
Contributor

@bossinc bossinc commented Sep 5, 2023

Functions passed into macros that have multiple args will parse correctly.

Before if your macro was select * from foo where $__params(FUNC(foo, bar)) it would parse the macro params as ["FUNC(foo", "bar)"]
It will now parse the params as ["FUNC(foo, bar)"]

I also created a Macro struct to make it clear which part is the macro name and args.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bossinc bossinc linked an issue Sep 5, 2023 that may be closed by this pull request
@bossinc bossinc requested review from sasklacz, a team, asimpson, aangelisc, adamyeats and alyssabull and removed request for a team September 5, 2023 23:39
@bossinc bossinc merged commit 4743948 into main Sep 6, 2023
0 of 3 checks passed
@bossinc bossinc deleted the macros/multi_param_func branch September 6, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macros that have nested functions with multi params do not work
3 participants