Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error source #99

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Error source #99

merged 4 commits into from
Oct 12, 2023

Conversation

scottlepp
Copy link
Collaborator

@scottlepp scottlepp commented Oct 10, 2023

define a default error source for SLOs. these can be overridden from the plugin

@scottlepp scottlepp requested review from marefr and a team October 10, 2023 20:39
Copy link

@cletter7 cletter7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious to learn what are the guidelines for differentiating between plugin and downstream errors. For example could the error during connection also be a plugin error if the implementation is incorrect?

@scottlepp
Copy link
Collaborator Author

scottlepp commented Oct 11, 2023

@cletter7 these are defaults. If you return a pluginerror from the connect method of the plugin, it will override the default that is defined here. I think its unlikely that by the time the plugin is released and battle tested that it will have implementation errors when connecting to a sql database, but yes it's possible and you can override the default.

@scottlepp scottlepp merged commit d99b10a into main Oct 12, 2023
3 checks passed
@scottlepp scottlepp deleted the error-source branch October 12, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants