Update backend API #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderzobnin
force-pushed
the
update-backend-api
branch
from
77497d6
to
e4db183
Compare
AgnesToulet
approved these changes
Oct 9, 2020
| return buildErrorResponse(err, nil), nil | ||
| for _, q := range req.Queries { | ||
| res := backend.DataResponse{} | ||
| res.Error = ErrAlertingNotSupported |
There was a problem hiding this comment.
Why are you always setting this error?
There was a problem hiding this comment.
Because plugin doesn't support alerting and error should be in each query response.
pkg/datasource/datasource.go
Outdated
Comment on lines
305
to
307
| query := tsdbReq | ||
| endpoint := query.Endpoint | ||
| params := query.Params |
There was a problem hiding this comment.
Is there a reason why you're not using tsdbReq directly?
There was a problem hiding this comment.
Hm, probably missed to change this after copying code :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update plugin backend according to the new datasource API.