Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64 support #27

Merged
merged 2 commits into from
May 13, 2021
Merged

arm64 support #27

merged 2 commits into from
May 13, 2021

Conversation

jontg
Copy link
Contributor

@jontg jontg commented Nov 1, 2020

Ref #11

Copy link
Collaborator

@alexanderzobnin alexanderzobnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a minor change required.

Makefile Outdated
dist-backend-windows_amd64: extension = .exe
dist-backend-linux_arm:
env GOOS=linux GOARCH=arm GOARM=6 go build -ldflags="-s -w" -mod=vendor -o ./dist/strava-plugin_linux_arm ./pkg
dist-backend-linux_arm64:
env GOOS=linux GOARCH=arm64 GOARM=6 go build -ldflags="-s -w" -mod=vendor -o ./dist/strava-plugin_linux_arm64 ./pkg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like GOARM is not applicable to the GOARCH=arm64:
https://github.com/golang/go/wiki/GoArm#supported-architectures

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super weird - I should be able to address this tonight, but the compiled binary appears to work on my pi cluster :-D

Makefile Outdated Show resolved Hide resolved
@alexanderzobnin alexanderzobnin self-requested a review May 13, 2021 07:24
@alexanderzobnin alexanderzobnin merged commit 4ff0bb6 into grafana:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants