Do authentication on the backend #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how do i upgrade this Plugin? im getting always the old Version. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts plugin to the backend plugin and fixes #2 by implementing proper auth flow on the backend. Obtained refresh tokens stored in files (one file for each data source) in plugin data folder. Default is a directory with plugin itself, but it can be removed after plugin update, so more stable solution is set data folder to grafana data folder via
GF_STRAVA_DS_DATA_PATHenv variable, likeDon't forget that directory should be exist.
Security note
Refresh token stored in file as a plain text and not encrypted. I think it's acceptable because refresh token can not be exchanged for access token without client secret which is encrypted and stored in Grafana database.