Release 1.5 #59
Merged
Release 1.5 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
peterholmberg
approved these changes
Aug 26, 2022
srclosson
approved these changes
Aug 26, 2022
| @@ -366,7 +366,7 @@ func (ds *StravaDatasourceInstance) StravaAPIQueryWithCache(requestHash string) | |||
| return nil, err | |||
| } | |||
| if query.Endpoint == "athlete/activities" { | |||
| ds.cache.SetWithExpiration(requestHash, response, time.Minute*5) | |||
| ds.cache.Set(requestHash, response) | |||
There was a problem hiding this comment.
Would be interested in a comment on why the expiration is no longer required
There was a problem hiding this comment.
Yeah, makes sense. Previously I used predefined cache TTL (5 min) for athlete/activities endpoint, but once I added cache TTL to data source config, I think it's better to use the same interval for all queries. My only concern is fetching recently added activities - it's not possible until cache is expired. Maybe I'll add some smart fetching in next release (always fetch data within cache TTL, like 1 hour, in separate query).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for 1.5 release