Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port to toolkit and mage #8

Merged
merged 6 commits into from
May 28, 2020
Merged

port to toolkit and mage #8

merged 6 commits into from
May 28, 2020

Conversation

srclosson
Copy link
Member

Hey Guys,
I've done this several times, and thought I would port this. Comments welcome :)

alexanderzobnin
alexanderzobnin requested changes May 28, 2020
View reviewed changes
Copy link
Collaborator

@alexanderzobnin alexanderzobnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you remove parts are not related to the migration to toolkit (like query editor and other)?

@alexanderzobnin alexanderzobnin self-requested a review May 28, 2020 10:25
@peterholmberg peterholmberg merged commit 9ff91c9 into use-grafana-toolkit May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderzobnin alexanderzobnin alexanderzobnin approved these changes

@peterholmberg peterholmberg Awaiting requested review from peterholmberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srclosson @alexanderzobnin @peterholmberg