Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set fixed overflow widgets on monaco editor #776

Merged
merged 1 commit into from Apr 30, 2024

Conversation

rdubrock
Copy link
Collaborator

This fixes the autosuggest window wandering away from the cursor for the check editor. The actual fix is adding fixedOverflowWidgets: false,, the rest is just reverting back the responsive layout.

I'm not sure why. It has something to do with how Monaco handles overflows, and how container is sizing things, but I'm unsure what's going on there

@rdubrock rdubrock requested a review from ckbedwell April 29, 2024 22:01
@rdubrock rdubrock requested a review from a team as a code owner April 29, 2024 22:01
Copy link
Contributor

@ckbedwell ckbedwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

As discussed on a call just now, the one downside of this solution is the responsiveness of the script editor degrades slightly.

Just for future lookups of this PR, will leave a link to this issue for Monaco as it looks like they are related: microsoft/monaco-editor#2793

This comment on the issue makes a reference to somebody solved it by removing all properties that lead to a new stacking context.

MDN's definition of a stacking context includes scenarios where an element with a container-type value of size or inline-size which is what is going on here.

@rdubrock rdubrock merged commit f26c900 into main Apr 30, 2024
5 checks passed
@rdubrock rdubrock deleted the add-back-responsive-editor branch April 30, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants