fix: terraform probes incorrectly formed #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The id can't be present in the custom probe resource configuration as otherwise terraform will fail
ckbedwell
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
Import custom probes into Terraformsection was displaying hardcoded data, not corresponding to the actual custom probes. This PR fixes that.⚠ Note: the terraform commands include the Auth token of each custom probe, but, as this is sensitive data, we don't have that information at that point. I'm adding a placeholder in its place so that users can paste it.
I also fixed the Terraform provider docs link as it was not very noticeable.
Fixes #787
Ref: https://registry.terraform.io/providers/grafana/grafana/latest/docs/resources/synthetic_monitoring_probe