Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add illumos to build constraints #13

Closed
wants to merge 2 commits into from

Conversation

szaydel
Copy link

@szaydel szaydel commented May 18, 2022

This small change enables building this code, and by extension promtail on illumos-based systems. Thank you in advance for considering this change.

Regards, Sam.

@CLAassistant
Copy link

CLAassistant commented Jun 15, 2022

CLA assistant check
All committers have signed the CLA.

@szaydel
Copy link
Author

szaydel commented Jun 15, 2022

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I would love to sign the CLA, but this is all I am seeing when I attempt to do it.
Screen Shot 2022-06-15 at 11 12 41

@szaydel
Copy link
Author

szaydel commented Jun 17, 2022

I think today it is actually working and I signed the CLA. Hopefully that's enough to move this forward.

@szaydel
Copy link
Author

szaydel commented Aug 6, 2022

Just wanted to bump this PR and see if there is anything standing in the way. This would really help with adoption on illumos-based systems.

Thanks!

@szaydel szaydel force-pushed the topic/szaydel/illumos-support branch from e486a02 to a0b6fa5 Compare July 4, 2023 12:48
@szaydel
Copy link
Author

szaydel commented Jul 4, 2023

Please let me know if I should withdraw this PR. It is now a much larger change than what it was initially. The problem is with the fsnotify package. Unfortunately, upstream has not yet released a version which has the necessary FEN support, which required the changes introduced in ed110e2. If this is unacceptable for the project, please let me know and we can close out this PR.

Thank you, Sam.

@szaydel szaydel closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants