Fix locking issue on Windows #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
There is but it would take a re architecture and then it would only be able to test that we close the file when |
MasslessParticle
added a commit
to grafana/loki
that referenced
this pull request
Oct 13, 2022
lxwzy
pushed a commit
to lxwzy/loki
that referenced
this pull request
Nov 7, 2022
changhyuni
pushed a commit
to changhyuni/loki
that referenced
this pull request
Nov 8, 2022
Abuelodelanada
pushed a commit
to canonical/loki
that referenced
this pull request
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometime a file is deleted but, instead of deleting the file, Windows puts it into the state
DeletePendingwhich isn't detected by this library. This PR detects theDeletePendingstate and responds by closing the file.