Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider showing diff before apply #17

Closed
tomwilkie opened this issue Aug 8, 2019 · 0 comments · Fixed by #34
Closed

Consider showing diff before apply #17

tomwilkie opened this issue Aug 8, 2019 · 0 comments · Fixed by #34
Labels
component/kubernetes Working with Kubernetes clusters kind/feature Something new should be added

Comments

@tomwilkie
Copy link
Contributor

So users don't accidentally apply the wrong thing.

Terraform went round and round on this and eventually settled on doing it.
@sh0rez sh0rez added component/kubernetes Working with Kubernetes clusters kind/feature Something new should be added labels Aug 8, 2019
@sh0rez sh0rez mentioned this issue Aug 9, 2019
Merged
@sh0rez sh0rez closed this as completed in #34 Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/kubernetes Working with Kubernetes clusters kind/feature Something new should be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): diff UX enhancements grafana/tanka
2 participants
@tomwilkie @sh0rez