Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tanka should manage the namespace resource #325

Closed
Duologic opened this issue Jul 24, 2020 · 8 comments
Closed

Tanka should manage the namespace resource #325

Duologic opened this issue Jul 24, 2020 · 8 comments
Labels
component/kubernetes Working with Kubernetes clusters keepalive kind/feature Something new should be added lifecycle/discuss An idea open for discussion

Comments

@Duologic
Copy link
Member

In the current setup, one needs to create the namespace manually or with k.core.v1.namepace. However, in line with letting Tanka set the namespace on a resource at runtime (based on the environment), it should also create and own a namespace if it doesn't exist already.

In this way, we completely mitigate the need of defining a namespace resource in Jsonnet and we wouldn't need a manual action to get one.

WDYT?

@Duologic Duologic added kind/feature Something new should be added component/kubernetes Working with Kubernetes clusters lifecycle/discuss An idea open for discussion labels Jul 24, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label kind/feature to this issue, with a confidence of 0.79. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@ghostsquad
Copy link

What if a namespace is part of the defined set of resources? I typically do this because I include labels and annotations to my namespaces.

Tanka could benefit from a concept of resource deploy ordering? Maybe that should be a separate issue?

@sh0rez
Copy link
Member

sh0rez commented Jul 24, 2020

@ghostsquad Tanka already sorts resources by dependency (namespaces + crd's first, etc).

This is probably about having the environment implicitely include it's default namespace, so you don't need to add it manually

@Duologic
Copy link
Member Author

Exactly, if a namespace is created and managed in the jsonnet code, tanka should not interfere (also because of backwards compat).

@ghostsquad
Copy link

@ghostsquad Tanka already sorts resources by dependency (namespaces + crd's first, etc).

@sh0rez is it possible to manipulate that ordering?

@stale
Copy link

stale bot commented Aug 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 23, 2020
@stale stale bot removed the stale label Aug 23, 2020
@ghostsquad
Copy link

Not stale

@sh0rez
Copy link
Member

sh0rez commented Jan 8, 2021

This has not come up in recent discussions, namespace handling appears to work just fine. Closing this issue.

Feel free to open another issue if urgent action becomes needed

@sh0rez sh0rez closed this as completed Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/kubernetes Working with Kubernetes clusters keepalive kind/feature Something new should be added lifecycle/discuss An idea open for discussion
Projects
None yet
Development

No branches or pull requests

3 participants