Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace in helm.template broken #677

Closed
harmjanblok opened this issue Mar 10, 2022 · 3 comments
Closed

Namespace in helm.template broken #677

harmjanblok opened this issue Mar 10, 2022 · 3 comments
Labels

Comments

@harmjanblok
Copy link
Contributor

harmjanblok commented Mar 10, 2022

The documentation for the Helm Support documents the possibility to specify the namespace of the generated templates. However the underlying helm template doesn't support this (anymore), see helm/helm#10737.

local tanka = import "github.com/grafana/jsonnet-libs/tanka-util/main.libsonnet";
local helm = tanka.helm.new(std.thisFile);

{
  grafana: helm.template("grafana", "./charts/grafana", {
    namespace: "monitoring",
  })
}

Assuming helm template will not (re)introduce support for specifying namespace, would you:

  • want to still support the namespace argument for helm.template
  • or do you want to drop this argument in favor of tankas default namespace behavior

Currently I'm using:

  • helm 3.8.0
  • tk 0.20.0
@Duologic
Copy link
Member

As mentioned here helm/helm#10737 (comment) I believe this will cause trouble in multiple places, not only Tanka.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot closed this as completed Apr 27, 2022
@rassie
Copy link

rassie commented Oct 30, 2022

This is certainly not "completed" or done in any sort of way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants